Skip to content

[WRFL-2471] puppeteer upgrade #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Aug 11, 2025
Merged

[WRFL-2471] puppeteer upgrade #624

merged 13 commits into from
Aug 11, 2025

Conversation

@aitchiss
Copy link
Contributor

@aitchiss aitchiss commented May 14, 2025 •
edited
Loading

This change is very similar to a previous one we had to revert in #544, but with some key differences:

  • Upgrades to an even more recent version of puppeteer
  • The minimum node version for this plugin was set to 18.14.0 earlier this year, and the previous issues with this change were only applicable to very old node versions (e.g. 12x)

Steps to test:

  • Using one of your netlify sites, set the dependency for the lighthouse plugin to use this branch, e.g. "@netlify/plugin-lighthouse": "https://github.com/netlify/netlify-plugin-lighthouse.git#sa/upgrade-puppeteer-with-cache-utils"
  • Verify you can run deploys successfully at a range of supported node versions

@netlify
Copy link

netlify bot commented May 14, 2025 •
edited
Loading

👷 Deploy Preview for plugin-lighthouse processing.

Name Link
🔨 Latest commit bdbe66f
🔍 Latest deploy log https://app.netlify.com/projects/plugin-lighthouse/deploys/689a6e42d6476300087d67b8

@aitchiss aitchiss marked this pull request as ready for review May 14, 2025 15:41
@aitchiss aitchiss requested a review from a team as a code owner May 14, 2025 15:41
@aitchiss aitchiss self-assigned this May 14, 2025
cmparsons
cmparsons previously approved these changes May 14, 2025
View reviewed changes
Copy link
Contributor

@cmparsons cmparsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Node 18, 20, and 22 and worked on my projects 👍

I noticed that some logs are duplicated. Is this expected?

CleanShot 2025-05-14 at 11 17 01@2x
CleanShot 2025-05-14 at 11 17 08@2x

@aitchiss
Copy link
Contributor Author

aitchiss commented May 14, 2025

I noticed that some logs are duplicated. Is this expected?

That's definitely strange - I'll see if I can figure out what's going on there

@aitchiss aitchiss force-pushed the sa/upgrade-puppeteer-with-cache-utils branch from ba1975d to 9fc3998 Compare June 6, 2025 11:57
@cmparsons
Copy link
Contributor

cmparsons commented Jun 6, 2025

I was still seeing duplicate lines as before, so I tried using the latest released version of the plugin to see if that made a difference but looks like I still see them.

So it may just be a me problem or an existing issue

https://app.netlify.com/projects/subtle-cheescake-pie-cake/deploys/68430335ca0aa40008ac9a0b#L202-L205

cmparsons
cmparsons previously approved these changes Jun 6, 2025
View reviewed changes
@aitchiss
Copy link
Contributor Author

aitchiss commented Jun 6, 2025

I was still seeing duplicate lines as before, so I tried using the latest released version of the plugin to see if that made a difference but looks like I still see them.

So it may just be a me problem or an existing issue

https://app.netlify.com/projects/subtle-cheescake-pie-cake/deploys/68430335ca0aa40008ac9a0b#L202-L205

Can you try clearing your cache and redeploying? Im wondering if it's still picking up the old version because the the actual version number of the plugin hasn't changed 🤔

@cmparsons
Copy link
Contributor

cmparsons commented Jun 6, 2025

I was still seeing duplicate lines as before, so I tried using the latest released version of the plugin to see if that made a difference but looks like I still see them.
So it may just be a me problem or an existing issue
https://app.netlify.com/projects/subtle-cheescake-pie-cake/deploys/68430335ca0aa40008ac9a0b#L202-L205

Can you try clearing your cache and redeploying? Im wondering if it's still picking up the old version because the the actual version number of the plugin hasn't changed 🤔

I deployed a new project with the same repo and saw the same duplicates lines https://app.netlify.com/projects/boisterous-rugelach-8cf636/deploys/68433433e6ebb0175ed4ee51#L151-L155

@aitchiss
Copy link
Contributor Author

aitchiss commented Jun 9, 2025

Hmm OK thanks for the test site link, clearly something is still very funky

@ndhoule
Copy link
Contributor

ndhoule commented Aug 11, 2025

Good news, everybody! I've made no changes and tested this on Node 18/20/22 on both Focal and Noble, and I can't reproduce the duplicate lines issue. I have fixed the problem!

@ndhoule ndhoule force-pushed the sa/upgrade-puppeteer-with-cache-utils branch from 3020b8e to bdbe66f Compare August 11, 2025 22:27
@ndhoule ndhoule merged commit 5efe04b into main Aug 11, 2025
10 checks passed
@ndhoule ndhoule deleted the sa/upgrade-puppeteer-with-cache-utils branch August 11, 2025 22:32
@token-generator-app token-generator-app bot mentioned this pull request Aug 11, 2025
Merged
@aitchiss
Copy link
Contributor Author

aitchiss commented Aug 12, 2025

Good news, everybody! I've made no changes and tested this on Node 18/20/22 on both Focal and Noble, and I can't reproduce the duplicate lines issue. I have fixed the problem!

whaaaaaa 😨 that is indeed very good news

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ndhoule ndhoule ndhoule approved these changes

@cmparsons cmparsons cmparsons left review comments

Assignees

@aitchiss aitchiss

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aitchiss @cmparsons @ndhoule